Idempotency fixes for etcd certs and resolvconf tasks #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
ci check this |
mattymo
force-pushed
the
idempotency-fixes
branch
from
b161446
to
f6b72fa
Compare
|
@bogdando are you free to check this out? |
holser
suggested changes
Mar 15, 2017
| backup: yes | ||
| follow: yes | ||
| with_nested: | ||
| - "{{ [resolvconffile] + [base|default('')] + [head|default('')] }}" |
There was a problem hiding this comment.
you may use map extract patter to have more understandable format
- "{{ [ resolvconffile, base|default(''), head|default('') ] | difference(['']) }}"
in this case you will not need to have 'when: item[0] != ""' condition
There was a problem hiding this comment.
I'll follow up with a small patch to fix this
holser
approved these changes
Mar 15, 2017
| @@ -114,7 +118,9 @@ | |||
| - name: Gen_certs | Prepare tempfile for unpacking certs | |||
| shell: mktemp /tmp/certsXXXXX.tar.gz | |||
| register: cert_tempfile | |||
|
|
|||
There was a problem hiding this comment.
IMHO
delegate_to: "{{groups['etcd']}}"
when: sync_certs|default(false) and inventory_hostname != groups['etcd'][0]
looks better
There was a problem hiding this comment.
It doesn't work that way... you have to loop with multiple delegate_to targets (which is slower). And we use the same rule many times.
hase1128
pushed a commit
to hase1128/kubespray
that referenced
this pull request
Feb 17, 2020
add doc about managing e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.