Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.22] fix(multus): loop_control template error when item is None (#10347) #10726

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Dec 15, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
Backport of #10347

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes templating with multus role when using --limit

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 15, 2023
@VannTen VannTen changed the title fix(multus): loop_control template error when item is None (#10347) [2.22]fix(multus): loop_control template error when item is None (#10347) Dec 15, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2023
@VannTen VannTen changed the title [2.22]fix(multus): loop_control template error when item is None (#10347) [2.22] fix(multus): loop_control template error when item is None (#10347) Dec 15, 2023
@yankay
Copy link
Member

yankay commented Dec 18, 2023

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2023
@VannTen
Copy link
Contributor Author

VannTen commented Dec 18, 2023

/assign @oomichi @mzaian

Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 336b323 into kubernetes-sigs:release-2.22 Dec 18, 2023
62 checks passed
notCalle pushed a commit to ModioAB/kubespray that referenced this pull request Dec 27, 2023
…s-sigs#10347) (kubernetes-sigs#10726)

Co-authored-by: Nicolas Goudry <nicolas-goudry@users.noreply.github.com>
(cherry picked from commit 336b323)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants