Cannot upgrade k8s cluster using cluster.yml, unless upgrade_cluster_setup is set to true

[hedayat]

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Environment:

• Cloud provider or hardware configuration: bare metal

• OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"): Fedora 29, Linux 4.20.3-200.fc29.x86_64 x86_64

• Version of Ansible (ansible --version):2.7.5

**Kubespray version (commit) (git rev-parse --short HEAD):**881be9b7

Command used to invoke ansible:
ansible-playbook -i my_inventory/single_node.ini cluster.yml

Anything else do we need to know:
The kubeadm rules only upgrade the cluster when upgrade_cluster_setup is true, but it is false by default and when cluster.yml is used. Either something should be changed, or the upgrade docs should be fixed to mention that -e upgrade_cluster_setup=true should be used in upgrades using cluster.yml.

[IpaliboWhyte]

I believe upgrade-cluster.yml should be used for upgrading the cluster and that has upgrade_cluster_setup set to true by default.

[hedayat]

Nope. Please see Kubespray upgrade doc. There is mainly 2 methods: 1. unsafe one, using cluster.yml and 2. safe one (graceful upgrade), which uses upgrade-cluster.yml

Upgrades using cluster.yml, including partial upgrades, are explicitly documented in upgrade docs.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[hedayat]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hedayat]

/reopen
/remove-lifecycle rotten

[k8s-ci-robot]

@hedayat: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[hedayat]

/remove-lifecycle stale

[Flowkap]

I literally searched a whole day to find this, We faced the same issue. All was upgraded but the actuall running control plane pods. Related to #4736

[Flowkap]

Opened #5609 to add info to the upgrade docs as that was actually the first place I went looking and found no hint.