Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ 🐛fix: remove duplicate HasFragment method, replaced by HasFileContentWith #4191

Merged

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Sep 23, 2024

The HasFragment method was mistakenly added, leading to code duplication. The existing HasFileContentWith method already handles the same functionality, so HasFragment has been removed to avoid redundancy.

The HasFragment was added by mistake resulting in a duplication on the code.
The method HasFileContentWith does the same
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
Copy link
Member Author

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing on the test result in be safe to move forward with this small fix.
We have many PRs open which we really need help on review so I will not make anybody waste time on this one. Moving forward.

@camilamacedo86 camilamacedo86 changed the title 🐛 fix remove HasFragment added by mistake since we have HasFileContentWith ⚠️ 🐛 fix remove HasFragment added by mistake since we have HasFileContentWith Sep 23, 2024
@camilamacedo86 camilamacedo86 changed the title ⚠️ 🐛 fix remove HasFragment added by mistake since we have HasFileContentWith ⚠️ 🐛fix: remove duplicate HasFragment method, replaced by HasFileContentWith Sep 23, 2024
@camilamacedo86 camilamacedo86 merged commit 9f80d59 into kubernetes-sigs:master Sep 23, 2024
15 of 20 checks passed
@camilamacedo86 camilamacedo86 deleted the remove-duplicated-method branch September 23, 2024 07:24
TAM360 pushed a commit to TAM360/kubebuilder that referenced this pull request Sep 26, 2024
…tentWith (kubernetes-sigs#4191)

The HasFragment method was mistakenly added, leading to code duplication. The existing HasFileContentWith method already handles the same functionality, so HasFragment has been removed to avoid redundancy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants