-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support to scaffold controllers for External Types #4171
base: master
Are you sure you want to change the base?
✨ Add support to scaffold controllers for External Types #4171
Conversation
a6977f9
to
389c644
Compare
7ea823d
to
040ae31
Compare
040ae31
to
965e005
Compare
Hi @fischor, @sundaram2021, See the changes here. We need to add the support for controllers first, ensure the docs, change in the PROJECT config and re-scaffold helper first for then we be able to work on with those sample supports for webhooks in a follow up. So, please feel free to help us in the review of this one for we are able to looking for in the next step. |
Hi @hardikdr, @kopiczko, @janik-io, @oliviermichaelis, @ctrought, @armsnyder, @samuelvl, @allenhaozi, @wangjiusi I know that you were looking for that. So, if you be able to help us with reviews that will be great. |
This comment was marked as duplicate.
This comment was marked as duplicate.
037edd2
to
9517ac2
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
testdata/project-v4-multigroup/internal/controller/certmanager/certificate_controller.go
Outdated
Show resolved
Hide resolved
62bbaa6
to
68c9bf7
Compare
Hi @fischor, See that we have a flag for the domain now and the new makers to scaffold the checks we can add/discuss in a follow so that we can shape those better and make easier the review. (We can describe the behaviour without to demo why that is required/recommended and etc) Thank you for your time on reviews. |
412b6c1
to
a1dbe01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just some minors left in the docs.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, fischor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Introduces the option to allow users scaffold controllers for external types by running: kubebuilder create api --group certmanager --version v1 --kind Certificate --controller=true --resource=false --make=false --external-api-path=github.com/cert-manager/cert-manager/pkg/apis/certmanager/v1 --external-api-domain=certmanager.io
a1dbe01
to
f070751
Compare
Hi @fischor Thank you a lot for your time and help with the review. 🥇 |
c/c @lingdie |
I think you all have been looking for that: |
Introduces the option to allow users scaffold controllers for external types by running:
Example
Partial Close: #1999
We need to either add the support for Core and External types for webhooks which is blocked by: #4150