✨ Add Network Policy #3853
Merged
✨ Add Network Policy #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
camilamacedo86
force-pushed
the
replace-auth-proxy
branch
11 times, most recently
from
234d7bb
to
6c03b83
Compare
camilamacedo86
changed the title
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
replace-auth-proxy
branch
6 times, most recently
from
8d3ca8d
to
e8770a5
Compare
camilamacedo86
force-pushed
the
replace-auth-proxy
branch
from
9a35677
to
4e15537
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
replace-auth-proxy
branch
2 times, most recently
from
bcdd426
to
671e531
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
replace-auth-proxy
branch
from
671e531
to
675b8b6
Compare
camilamacedo86
added
priority/backlog
erikgb
reviewed
Jul 21, 2024
docs/book/src/cronjob-tutorial/testdata/project/config/policy/allow-metrics-traffic.yaml
Outdated
Show resolved
Hide resolved
camilamacedo86
force-pushed
the
replace-auth-proxy
branch
5 times, most recently
from
14274c5
to
38a2f86
Compare
camilamacedo86
force-pushed
the
replace-auth-proxy
branch
from
38a2f86
to
fceebdb
Compare
|
Hi @erikgb All suggestions were addressed. |
|
I think this one is great to fly !!! |
|
Took a second pass, and the changes look good. I'll just try these out by end of this week and update here! Thanks Camila! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, users will be able to use a helper using network policies to protected the metrics endpoint. If webhooks are scaffold then, a Network Policy to allow the traffic within is also added to the project.
Motivations
Partially Close: #3871