Update documentation wsl shutdown command issue1977 #1994

gunadhya · 2020-12-29T10:31:26Z

Fixes #1977 Documentation fix in using-wsl2.md
Before:
wsl <distro> --shutdown
After:
wsl --shutdown <distro>

k8s-ci-robot · 2020-12-29T10:31:29Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-12-29T10:31:34Z

Welcome @gunadhya!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-12-29T10:31:34Z

Hi @gunadhya. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gunadhya · 2020-12-29T10:37:09Z

I signed it

gunadhya · 2020-12-29T10:46:40Z

/check-cla

gunadhya · 2020-12-29T10:50:15Z

https://deploy-preview-1994--k8s-kind.netlify.app/docs/user/using-wsl2/

gunadhya · 2020-12-29T11:09:45Z

/check-cla

aojea · 2020-12-29T14:14:41Z

hmm this says that shutdown doesn't accept any arguments
microsoft/WSL#4539

gunadhya · 2020-12-29T14:29:07Z

@aojea I tried it on my system and seems to work. I'm using wsl2.

aojea · 2020-12-29T17:21:47Z

cool, thanks
/lgtm
/ok-to-test
/assign @BenTheElder

aojea · 2020-12-29T23:38:11Z

/hold

should we use terminate instead of shutdown?
#1977 (comment)

gunadhya · 2020-12-30T06:22:03Z

I've replaced shutdown command with terminate.

aojea · 2020-12-30T06:49:21Z

site/content/docs/user/using-wsl2.md

@@ -86,6 +86,6 @@ nodes:

 ## Helpful Tips for WSL2

- If you want to shutdown the WSL2 instance to save memory or "reboot", open an admin PowerShell prompt and run `wsl --shutdown <distro>`. Closing a WSL2 window doesn't shut it down automatically.
+- If you want to terminate the WSL2 instance to save memory or "reboot", open an admin PowerShell prompt and run `wsl -t <distro>`. Closing a WSL2 window doesn't shut it down automatically.


I prefer the long flag format for documentation purposes

aojea · 2020-12-30T06:50:08Z

Squash the commits please, we only need one commit for this change

aojea · 2020-12-30T07:53:03Z

/hold cancel
/lgtm
thanks

aojea · 2020-12-30T17:10:01Z

/retest

BenTheElder · 2020-12-31T20:18:07Z

/approve

k8s-ci-robot · 2020-12-31T20:18:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, gunadhya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 29, 2020

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 29, 2020

k8s-ci-robot requested review from amwat and neolit123 December 29, 2020 10:31

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 29, 2020

gunadhya changed the title ~~Fixes #1977-Update wsl shutdown command~~ Fixes #1977-Update documentation wsl shutdown command Dec 29, 2020

gunadhya changed the title ~~Fixes #1977-Update documentation wsl shutdown command~~ Update documentation wsl shutdown command issue1977 Dec 29, 2020

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 29, 2020

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 29, 2020

k8s-ci-robot assigned BenTheElder Dec 29, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 29, 2020

k8s-ci-robot assigned aojea Dec 29, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2020

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2020

aojea mentioned this pull request Dec 29, 2020

Documentation bug in "using-wsl2.md" #1977

Closed

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2020

aojea reviewed Dec 30, 2020

View reviewed changes

Replaced Shutdown with Terminate in using-wsl.md

b409517

gunadhya force-pushed the patch-1 branch from bc66206 to b409517 Compare December 30, 2020 07:48

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 30, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2020

k8s-ci-robot merged commit 8ea030b into kubernetes-sigs:master Dec 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update documentation wsl shutdown command issue1977 #1994

Update documentation wsl shutdown command issue1977 #1994

gunadhya commented Dec 29, 2020 •

edited

Loading

k8s-ci-robot commented Dec 29, 2020

k8s-ci-robot commented Dec 29, 2020

k8s-ci-robot commented Dec 29, 2020

gunadhya commented Dec 29, 2020

gunadhya commented Dec 29, 2020

gunadhya commented Dec 29, 2020

gunadhya commented Dec 29, 2020

aojea commented Dec 29, 2020

gunadhya commented Dec 29, 2020

aojea commented Dec 29, 2020

aojea commented Dec 29, 2020 •

edited

Loading

gunadhya commented Dec 30, 2020

aojea Dec 30, 2020

aojea commented Dec 30, 2020

aojea commented Dec 30, 2020

aojea commented Dec 30, 2020

BenTheElder commented Dec 31, 2020

k8s-ci-robot commented Dec 31, 2020

Update documentation wsl shutdown command issue1977 #1994

Update documentation wsl shutdown command issue1977 #1994

Conversation

gunadhya commented Dec 29, 2020 • edited Loading

k8s-ci-robot commented Dec 29, 2020

k8s-ci-robot commented Dec 29, 2020

k8s-ci-robot commented Dec 29, 2020

gunadhya commented Dec 29, 2020

gunadhya commented Dec 29, 2020

gunadhya commented Dec 29, 2020

gunadhya commented Dec 29, 2020

aojea commented Dec 29, 2020

gunadhya commented Dec 29, 2020

aojea commented Dec 29, 2020

aojea commented Dec 29, 2020 • edited Loading

gunadhya commented Dec 30, 2020

aojea Dec 30, 2020

Choose a reason for hiding this comment

aojea commented Dec 30, 2020

aojea commented Dec 30, 2020

aojea commented Dec 30, 2020

BenTheElder commented Dec 31, 2020

k8s-ci-robot commented Dec 31, 2020

gunadhya commented Dec 29, 2020 •

edited

Loading

aojea commented Dec 29, 2020 •

edited

Loading