-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GoDaddy domains with PENDING_DNS_ACTIVE status #3889
Conversation
Welcome @m-adawi! |
Hi @m-adawi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
I have a non-blocking suggestion, see my comment. |
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
/lgtm |
@seanmalloy doesn't seem to be active on GitHub recently, is it okay if I ask someone else from the owners to review this for approval? @johngmyers @mloiseleur |
/assign @Raffo |
/retittle feat(godaddy): support domains with PENDING_DNS_ACTIVE status |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Description
The problem in issue #3888 is that GoDaddy marks domains that aren't registered by GoDaddy itself with the status "PENDING_DNS_ACTIVE" instead of "ACTIVE". External-DNS filters these domains and only selects domains with the status "ACTIVE", using the statuses request parameter. To solve this issue, I'm including results with both statuses.
Checklist