-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): comply with Pod Security Standards #3689
Conversation
Welcome @nrvnrvn! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @nrvnrvn. Could you add this to the chart CHANGELOG?
@stevehipwell updated the changelog. |
/ok-to-test |
@nrvnrvn if you rebase onto |
@stevehipwell synced with |
@nrvnrvn the automation is working correctly but it looks like the code change doesn't work? |
hmm.. I am trying to compare with the previous successful lint-test job https://github.com/kubernetes-sigs/external-dns/actions/runs/4810641872/jobs/8563541759. Not sure why |
Have you tested your changes locally on a Kind cluster? |
I have tested it on a live cluster manually applying the changes in the security context and via |
@stevehipwell jfyi: `git checkout external-dns-helm-chart-1.12.2`
`git checkout external-dns-helm-chart-1.13.0`
If I am not mistaken this is the reason: 07dc39a
|
I suggest to change default provider from running |
@nrvnrvn good spot. If you add a |
/label tide/merge-method-squash |
@stevehipwell done |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur, nrvnrvn, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
Fixes #3688
Checklist