Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes v1.22: Update controller to use networking.k8s.io/v1 Ingress. #2281

Merged

Conversation

andrewstuart
Copy link
Contributor

Description

This PR should fix the problem of external-dns not running in v1.22. It does not provide backwards compatibility for extensions/v1beta1 ingresses as this should still be backwards compatible going back to v1.19 without any other code; I don't know the typical policy for this SIG, but given that v1beta1 Ingress has been removed, this seems safe enough (and much simpler).

Fixes #2168

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @andrewstuart!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2021
@larivierec
Copy link
Contributor

exciting, i'm waiting on this to use it in my setup 🎉

@Raffo
Copy link
Contributor

Raffo commented Sep 15, 2021

@andrewstuart I think this is a fair change and as breaking as it could be, it's has been plenty of kubernetes releases already that those APIVersions are available.

@Raffo
Copy link
Contributor

Raffo commented Sep 15, 2021

/lgmt
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewstuart, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@Raffo
Copy link
Contributor

Raffo commented Sep 15, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 49e24a5 into kubernetes-sigs:master Sep 15, 2021
@andrewstuart andrewstuart deleted the bugfix/netv1-ingress branch September 15, 2021 21:07
@admoca60
Copy link

Could anyone give me some help about when this issue is expected to be released? Currently I could see that it's in master branch, but I don't know if this issue will be include in next release (I suppose yes) and when next release will be ready to be used.

Thank you so much!

@larivierec
Copy link
Contributor

Could anyone give me some help about when this issue is expected to be released? Currently I could see that it's in master branch, but I don't know if this issue will be include in next release (I suppose yes) and when next release will be ready to be used.

Thank you so much!

Hello Adrian,

See this for more info: #1861 (comment)

@stuartpb
Copy link
Contributor

Don't forget to update the Helm chart!

@mstrohl
Copy link

mstrohl commented Sep 19, 2021

hello folks, just build the image from this merge on master : docker.io/smartdeploy/external-dns:latest . Thanks to all by the way i just upgrade my helm install.

@stuartpb
Copy link
Contributor

@Raffo Any word on that new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExternalDNS does not support K8s 1.22
7 participants