Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial code for capibmadm tool #1027

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Add initial code for capibmadm tool #1027

merged 1 commit into from
Jan 25, 2023

Conversation

Karthik-K-N
Copy link
Contributor

What this PR does / why we need it:

This PR contains the initial skeleton code for capibmadm tool.
Reference document

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #534

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Jan 12, 2023
@netlify
Copy link

netlify bot commented Jan 12, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 95ec7ea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/63d0c2e02a5bea00085334ea
😎 Deploy Preview https://deploy-preview-1027--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 12, 2023
@Karthik-K-N Karthik-K-N force-pushed the capibmadm branch 2 times, most recently from 134591d to d0faeab Compare January 12, 2023 14:37
@Karthik-K-N
Copy link
Contributor Author

I will fix the CI failures soon but would like to know opinion on directory structures, formats so on.

cc @mkumatag @dharaneeshvrd @Prajyot-Parab @Amulyam24

mkumatag
mkumatag requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following directory can be better

cmd/capibmadm/root.go
cmd/capibmadm/main.go
cmd/capibmadm/powervs/...
cmd/capibmadm/vpc/...

@Karthik-K-N
Copy link
Contributor Author

following directory can be better

cmd/capibmadm/root.go
cmd/capibmadm/main.go
cmd/capibmadm/powervs/...
cmd/capibmadm/vpc/...

ok, But usually cobra commands grouped under cmd directory,
Example: https://github.com/spf13/cobra/blob/main/user_guide.md
https://github.com/kubernetes-sigs/cluster-api/tree/2c0b80adbae0136e191b70f5d511cae7f803626e/cmd/clusterctl/cmd

@Karthik-K-N Karthik-K-N force-pushed the capibmadm branch 2 times, most recently from 2bd1c80 to 2de9956 Compare January 17, 2023 09:32
@mkumatag
Copy link
Member

Lets wait for #1030 to merge

mkumatag
mkumatag requested changes Jan 18, 2023
View reviewed changes
cmd/capibmadm/cmd/powervs/network/create.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/network/create.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/network/create.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/powervs.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/powervs.go Outdated Show resolved Hide resolved
mkumatag
mkumatag requested changes Jan 19, 2023
View reviewed changes
cmd/capibmadm/cmd/powervs/powervs.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/powervs.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/powervs.go Outdated Show resolved Hide resolved
cmd/capibmadm/util/util.go Outdated Show resolved Hide resolved
@Karthik-K-N Karthik-K-N force-pushed the capibmadm branch 2 times, most recently from 271eaf4 to db0e875 Compare January 19, 2023 06:44
mkumatag
mkumatag requested changes Jan 20, 2023
View reviewed changes
cmd/capibmadm/cmd/powervs/network/network.go Outdated Show resolved Hide resolved
cmd/capibmadm/cmd/powervs/network/network.go Outdated Show resolved Hide resolved
cmd/capibmadm/options/options.go Outdated Show resolved Hide resolved
@Karthik-K-N
Copy link
Contributor Author

Addressed the review comments and PR is ready for next review.

@Karthik-K-N Karthik-K-N mentioned this pull request Jan 20, 2023
Closed
16 tasks
mkumatag
mkumatag requested changes Jan 23, 2023
View reviewed changes
cmd/capibmadm/options/options.go Outdated Show resolved Hide resolved
@Karthik-K-N Karthik-K-N force-pushed the capibmadm branch 2 times, most recently from 074d79e to bb9197c Compare January 23, 2023 11:45
mkumatag
mkumatag requested changes Jan 23, 2023
View reviewed changes
docs/book/src/topics/capibmadm/powervs/network.md Outdated Show resolved Hide resolved
docs/book/src/topics/capibmadm/powervs/network.md Outdated Show resolved Hide resolved
docs/book/src/topics/capibmadm/powervs/network.md Outdated Show resolved Hide resolved
@Karthik-K-N Karthik-K-N force-pushed the capibmadm branch 2 times, most recently from ee6b439 to 39d8b69 Compare January 25, 2023 05:12
mkumatag
mkumatag approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the initial version, will enhance it further..

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@mkumatag
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9b2df86 into kubernetes-sigs:main Jan 25, 2023
@Karthik-K-N Karthik-K-N mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

@relyt0925 relyt0925 Awaiting requested review from relyt0925

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI tool for admin purpose
4 participants
@Karthik-K-N @mkumatag @k8s-ci-robot @Prajyot-Parab