Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet uses --config to set some parameters #3873

Closed
lzhecheng opened this issue Aug 23, 2023 · 4 comments
Closed

kubelet uses --config to set some parameters #3873

lzhecheng opened this issue Aug 23, 2023 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lzhecheng
Copy link
Contributor

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
It seems capz is not using --config for kubelet parameters currently. Is it in the roadmap?

Flag --container-runtime-endpoint has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag

https://storage.googleapis.com/kubernetes-jenkins/logs/cloud-provider-azure-master-capz/1694016826222055424/artifacts/clusters/capz-v66bu4/machines/capz-v66bu4-control-plane-77lrz/kubelet.log

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 23, 2023
@CecileRobertMichon
Copy link
Contributor

@lzhecheng this might be a better question for the kubeadm folks. CAPZ is not configuring kubelet, only using kubeadm init and kubeadm join to join the nodes.

is container-runtime-endpoint getting set as an extra kubelet arg in the template you're using in this context?

@lzhecheng
Copy link
Contributor Author

@lzhecheng this might be a better question for the kubeadm folks. CAPZ is not configuring kubelet, only using kubeadm init and kubeadm join to join the nodes.

is container-runtime-endpoint getting set as an extra kubelet arg in the template you're using in this context?

No, this job is using standard capz cluster template. So args should be only azure-container-registry-config and cloud-provider. I don't know where this arg comes from...

@CecileRobertMichon
Copy link
Contributor

It gets set by kubeadm https://github.com/kubernetes/kubernetes/blob/714e77595c8b19b693925bda2a96ab80c307d38f/cmd/kubeadm/app/phases/kubelet/flags.go#L79

looks like this is already tracked in kubernetes/kubeadm#2902

/close

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closing this issue.

In response to this:

It gets set by kubeadm https://github.com/kubernetes/kubernetes/blob/714e77595c8b19b693925bda2a96ab80c307d38f/cmd/kubeadm/app/phases/kubelet/flags.go#L79

looks like this is already tracked in kubernetes/kubeadm#2902

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Archived in project
Development

No branches or pull requests

3 participants