-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ ec2: Add support for userdata privacy #1490
✨ ec2: Add support for userdata privacy #1490
Conversation
695bae7
to
24ddd6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't made it quite all the way through, but it's EOW for me, so I wanted to submit what I have. Huge thanks for putting this together!
877ceac
to
4180851
Compare
442ea6e
to
e02dc3c
Compare
/hold |
8a2c011
to
880c6f8
Compare
e5f795e
to
25c208f
Compare
rebasing for new conversion gen |
25c208f
to
1101019
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
argh. some of these converted function names changed |
1101019
to
02d50da
Compare
linters are appeased |
waiting for green CI |
done |
/lgtm |
Need to make sure we record action-required changes to the IAM policy b/c of this PR in the release notes. |
Signed-off-by: Naadir Jeewa jeewan@vmware.com
What this PR does / why we need it:
Re-introduction of #189
Fixes #1387
Fixes #1410
Fixes #1510
Optionally modifies the userdata to make use of a multi-part MIME archive to make cloud-init download userdata from AWS Secrets Manager.
In support of ensuring secrets are deleted as soon as they are not useful, the EC2 state machine has been refined to skip over operations that cannot occur on terminating and terminated instances.