Add unit test for MachineScope.GetBootstrapData()

[ncdc]

To ensure we don't regress on base64 encoding

/help
/good-first-issue
/milestone v0.5.0
/priority important-longterm

[k8s-ci-robot]

@ncdc:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

To ensure we don't regress on base64 encoding

/help
/good-first-issue
/milestone v0.5.0
/priority important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vincepri]

We should also have a unit test in one of the create instance mock functions

[neeleshkorade]

/assign

[neeleshkorade]

We should also have a unit test in one of the create instance mock functions

@vincepri could you elaborate this bit more? Particularly- could you point me to a create instance mock function?

[vincepri]

I was talking about this function https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/pkg/cloud/services/ec2/instances_test.go#L262. You can either add a new test or modify an existing one to test the behavior we expect.

[ncdc]

@neeleshkorade are you still interested in working on this?

[neeleshkorade]

Yes, I am. I am traveling so couldn’t get to it. Would be great if you could allow me couple days more.

…

On Tue, Jan 28, 2020 at 2:21 AM Andy Goldstein ***@***.***> wrote: @neeleshkorade <https://github.com/neeleshkorade> are you still interested in working on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1410?email_source=notifications&email_token=ABMF2YQA3H6YXA2LNGUFRQLQ74Q2XA5CNFSM4JZEO3MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKAQ66A#issuecomment-578883448>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMF2YXLL6FSFAIOWDDL67TQ74Q2XANCNFSM4JZEO3MA> .

[ncdc]

Sure thing - just checking in. Thanks!

[randomvariable]

@neeleshkorade maybe worth holding on slightly. i've had to refactor those calls a bit to clean up the use of Secrets Manager in #1490

[neeleshkorade]

Thanks @randomvariable will wait for #1490 to go in