-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for MachineScope.GetBootstrapData() #1410
Comments
@ncdc: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We should also have a unit test in one of the create instance mock functions |
/assign |
@vincepri could you elaborate this bit more? Particularly- could you point me to a |
I was talking about this function https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/pkg/cloud/services/ec2/instances_test.go#L262. You can either add a new test or modify an existing one to test the behavior we expect. |
@neeleshkorade are you still interested in working on this? |
Yes, I am. I am traveling so couldn’t get to it. Would be great if you
could allow me couple days more.
…On Tue, Jan 28, 2020 at 2:21 AM Andy Goldstein ***@***.***> wrote:
@neeleshkorade <https://github.com/neeleshkorade> are you still
interested in working on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1410?email_source=notifications&email_token=ABMF2YQA3H6YXA2LNGUFRQLQ74Q2XA5CNFSM4JZEO3MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKAQ66A#issuecomment-578883448>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMF2YXLL6FSFAIOWDDL67TQ74Q2XANCNFSM4JZEO3MA>
.
|
Sure thing - just checking in. Thanks! |
@neeleshkorade maybe worth holding on slightly. i've had to refactor those calls a bit to clean up the use of Secrets Manager in #1490 |
Thanks @randomvariable will wait for #1490 to go in |
To ensure we don't regress on base64 encoding
/help
/good-first-issue
/milestone v0.5.0
/priority important-longterm
The text was updated successfully, but these errors were encountered: