-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase service idle max timeout to 100 minutes #4361
Increase service idle max timeout to 100 minutes #4361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.27 |
@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.27 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.26 |
@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.26 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.25 |
@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.25 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@feiskyer: new pull request created: #4383 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@feiskyer: new pull request created: #4384 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@feiskyer: new pull request could not be created: failed to create pull request against kubernetes-sigs/cloud-provider-azure#release-1.25 from head k8s-infra-cherrypick-robot:cherry-pick-4361-to-release-1.25: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","field":"head","code":"invalid"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This updates the max value description of service.beta.kubernetes.io/azure-load-balancer-tcp-idle-timeout from 30 to 100. Previously the max value was limited to 30 but now it's incresed to fit the underlying ALB capability. Configurable TCP Idle timeout limit does not match Azure limit kubernetes-sigs/cloud-provider-azure#4360 Increase service idle max timeout to 100 minutes kubernetes-sigs/cloud-provider-azure#4361
What type of PR is this?
/kind bug
What this PR does / why we need it:
Resolves #4360 by increasing the allowed limit inline with Azures updated limits
Which issue(s) this PR fixes:
Fixes #4360
Special notes for your reviewer:
This limit has been increased on the Azure side and is documented now as 100 minutes maximum, links in the attached issue
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: