This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Update reserved storage flag name #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1410 +/- ##
=======================================
Coverage 37.53% 37.53%
=======================================
Files 74 74
Lines 4534 4534
=======================================
Hits 1702 1702
Misses 2597 2597
Partials 235 235Continue to review full report at Codecov.
|
mumoshu
approved these changes
Jul 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems
storageis no longer a valid value since k8s 1.8.Fixes
failed to run Kubelet: cannot reserve "storage" resourceRef https://kubernetes.io/docs/tasks/administer-cluster/reserve-compute-resources/ and kubernetes/kops#3576 and kubernetes/website#9532.