Skip to content
This repository has been archived by the owner on Mar 26, 2021. It is now read-only.

Commit

Permalink
Merge pull request #38278 from hodovska/external-name-no-ports
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue

API v1: do not require ports for all types of services

Ports values had to be specified for all types of services but object with service type "ExternalName" does't define ports. That's why we had to remove required condition.
Presence of ports in service types where ports are actually required is verified here: 
https://github.com/kubernetes/kubernetes/blob/master/pkg/api/validation/validation.go#L2439

For more information about ExternalName services see:
http://kubernetes.io/docs/user-guide/services/#services-without-selectors

Fixes kubernetes/kubernetes#34394
  • Loading branch information
Kubernetes Submit Queue committed Dec 9, 2016
2 parents 9f7644b + 9b04620 commit 796e821
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions apis/openapi-spec/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -9774,9 +9774,6 @@
},
"v1.ServiceSpec": {
"description": "ServiceSpec describes the attributes that a user creates on a service.",
"required": [
"ports"
],
"properties": {
"clusterIP": {
"description": "clusterIP is the IP address of the service and is usually assigned randomly by the master. If an address is specified manually and is not in use by others, it will be allocated to the service; otherwise, creation of the service will fail. This field can not be changed through updates. Valid values are \"None\", empty string (\"\"), or a valid IP address. \"None\" can be specified for headless services when proxying is not required. Only applies to types ClusterIP, NodePort, and LoadBalancer. Ignored if type is ExternalName. More info: http://kubernetes.io/docs/user-guide/services#virtual-ips-and-service-proxies",
Expand Down

0 comments on commit 796e821

Please sign in to comment.