-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added backoff parameters to external attacher #141
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @barp. Thanks for your PR. I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the PR! Can you work on signing the CLA? |
ping cla bot |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barp, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This looks consistent with external-provisioner |
@barp, can you please update README.md with the new parameters? Both "Command line options" and "CSI error and timeout handling" need a small change. |
/release-note |
@msau42: the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manually added the release note label. Unsure if the bot is able to add labels to already merged prs |
Shamelessly aped off kubernetes-csi/external-attacher#141 Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
Shamelessly aped off kubernetes-csi/external-attacher#141 Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds --retry-interval-max and --retry-interval-start to the attacher parameters to allow users to limit the exponential backoff retry time for requests.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: