Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backoff parameters to external attacher #141

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

barp
Copy link
Contributor

@barp barp commented Apr 15, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds --retry-interval-max and --retry-interval-start to the attacher parameters to allow users to limit the exponential backoff retry time for requests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Adds --retry-interval-max and --retry-interval-start to the csi-attacher parameters to allow users to limit the exponential backoff retry time for requests.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @barp. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 15, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 15, 2019

Thanks for the PR! Can you work on signing the CLA?

@msau42
Copy link
Collaborator

msau42 commented Apr 16, 2019

ping cla bot

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 16, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 16, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 16, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barp, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 16, 2019

This looks consistent with external-provisioner

@k8s-ci-robot k8s-ci-robot merged commit e16f1bc into kubernetes-csi:master Apr 16, 2019
@jsafrane
Copy link
Contributor

@barp, can you please update README.md with the new parameters? Both "Command line options" and "CSI error and timeout handling" need a small change.

@msau42
Copy link
Collaborator

msau42 commented Apr 19, 2019

/release-note

@k8s-ci-robot
Copy link
Contributor

@msau42: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msau42 msau42 added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 19, 2019
@msau42
Copy link
Collaborator

msau42 commented Apr 19, 2019

Manually added the release note label. Unsure if the bot is able to add labels to already merged prs

zuzzas added a commit to flant/external-resizer that referenced this pull request Mar 5, 2020
Shamelessly aped off kubernetes-csi/external-attacher#141

Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
zuzzas added a commit to flant/external-resizer that referenced this pull request Mar 5, 2020
Shamelessly aped off kubernetes-csi/external-attacher#141

Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants