Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for MXJob #2150

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

tariq-hasan
Copy link
Contributor

What this PR does / why we need it:

This PR addresses the deprecation of MXJob from Training Operator.

Related PR: #1953

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1996

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9655675174

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 34.9%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/training-operator.v1/main.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 9543811102: -0.5%
Covered Lines: 3944
Relevant Lines: 11301

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9655678457

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 34.926%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/training-operator.v1/main.go 0 1 0.0%
Totals Coverage Status
Change from base Build 9543811102: -0.4%
Covered Lines: 3947
Relevant Lines: 11301

💛 - Coveralls

@andreyvelich
Copy link
Member

Thank you for working on this @tariq-hasan!
We should merge this after Training Operator 1.8 release is finalized.
/hold

@andreyvelich
Copy link
Member

I think, we should be ready to merge it since Training Operator 1.8 was released.
@tariq-hasan please can you rebase your PR ?

@tariq-hasan tariq-hasan force-pushed the remove-apache-mxnet branch 2 times, most recently from 69b8ac4 to fef7ee7 Compare July 26, 2024 21:13
@coveralls
Copy link

coveralls commented Jul 26, 2024

Pull Request Test Coverage Report for Build 10121292822

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 34.908%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/training-operator.v1/main.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 81.05%
Totals Coverage Status
Change from base Build 10049707114: -0.5%
Covered Lines: 3945
Relevant Lines: 11301

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@terrytangyuan
Copy link
Member

/lgtm

@tariq-hasan
Copy link
Contributor Author

Looking into the failed integration tests now.

Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>
@tariq-hasan
Copy link
Contributor Author

/rerun-workflow "integration test"

@tariq-hasan
Copy link
Contributor Author

I updated manifests/base/webhook/patch.yaml to fix the integration tests.

If we re-run the integration tests all of them should pass now.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 736c814 into kubeflow:master Jul 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate MXJob from Training Operator
5 participants