-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TFJob examples to TensorFlow 2 #2023
Migrate TFJob examples to TensorFlow 2 #2023
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sandipanpanda The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandipanpanda Have you tried to build and run these in your local?
I guess that some of these couldn't be buildable or runnable.
@kubeflow/wg-training-leads Could you approve CI? |
Pull Request Test Coverage Report for Build 8224250888Details
💛 - Coveralls |
Oh, CI proves that all images are buildable. |
Thank you for your contribution @sandipanpanda 🎉 I am pretty sure that some TensorFlow APIs that we are using in examples are not compatible with TensorFlow 2.0. For example, So you might need to run these examples manually to migrate to Tensorflow 2.0 unless we will add them to our CI. |
Signed-off-by: Sandipan Panda <samparksandipan@gmail.com>
Run the automated script to convert some of TF1.x API usage to tf.compat.v1. Signed-off-by: Sandipan Panda <samparksandipan@gmail.com>
995048a
to
d0f8d10
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@tenzen-y @andreyvelich Thank you for reviewing. I have started working on migrating TFJob examples to TensorFlow 2 using the migration guide.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @sandipanpanda, do you have time to finalize this PR ? |
Hi, I am sorry I lack the bandwidth to work on this for the next couple of weeks. |
What this PR does / why we need it:
Upgrade TensorFlow version in all Dockerfiles to v2
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Part of #2015