Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Examples for v1alpha2 version #56

Merged
merged 4 commits into from
Aug 30, 2018
Merged

Examples for v1alpha2 version #56

merged 4 commits into from
Aug 30, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Aug 29, 2018 •
edited by jose5918
Loading

Adding config examples for v1alpha2 version

This change is Reviewable

@coveralls
Copy link

coveralls commented Aug 29, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 62.459% when pulling 533d72a on johnugeorge:examples into d657ace on kubeflow:master.

jose5918
jose5918 reviewed Aug 29, 2018
View reviewed changes
Copy link
Contributor

@jose5918 jose5918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnugeorge LGTM but if you're going to push containers for the new API version shouldn't the e2e test be changed to use that version?

@johnugeorge
Copy link
Member Author

@jose5918 Yes. it has to be changed once kubeflow/kubeflow#1441 is merged . The default version is set to be v1alpha1 for now.

Our e2e tests do not use config examples(in the PR) directly. They use https://github.com/kubeflow/pytorch-operator/blob/master/test/e2e/main.go i will add e2e tests for v1alpha2 soon.

@jose5918
Copy link
Contributor

/lgtm

@jose5918
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jose5918

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 566340c into kubeflow:master Aug 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jose5918 jose5918 jose5918 left review comments

@elsonrodriguez elsonrodriguez Awaiting requested review from elsonrodriguez

Assignees

@jose5918 jose5918

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnugeorge @coveralls @jose5918 @k8s-ci-robot