Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a ksonnet package for injecting credentials through pod presets #782

Merged
merged 2 commits into from
May 11, 2018
Merged

Create a ksonnet package for injecting credentials through pod presets #782

merged 2 commits into from
May 11, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented May 9, 2018

Create a prototype for injecting GCP Service Account Credentials

/assign @jlewi
/assign @lluunn
/cc @elsonrodriguez

Fixes #732


This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented May 10, 2018

/lgtm
/approve

/hold

Anyone else have comments?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankushagarwal
Copy link
Contributor Author

/hold cancel

@ankushagarwal
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 982d05a into kubeflow:master May 11, 2018
@ankushagarwal ankushagarwal deleted the podpreset branch May 11, 2018 23:11
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
kubeflow#782)

* Create a package for injecting credentials through pod presets

Fixes kubeflow#732

* Typos
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* fix: Remove

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Remove in workflow

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Remove

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants