Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in UG #599

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Typo in UG #599

merged 1 commit into from
Apr 6, 2018

Conversation

pdmack
Copy link
Member

@pdmack pdmack commented Apr 6, 2018

This change is Reviewable

@pdmack
Copy link
Member Author

pdmack commented Apr 6, 2018

/assign @ankushagarwal

Copy link

@inc0 inc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ankushagarwal
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankushagarwal, inc0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3d5e099 into kubeflow:master Apr 6, 2018
@pdmack pdmack deleted the patch-5 branch April 22, 2018 16:27
jlewi added a commit to jlewi/kubeflow that referenced this pull request May 22, 2018
* K8s doesn't support installing multiple versions of a CRD in the same cluster.
* So we add an option to choose which version to support.
* We don't add an E2E test in this PR because its not straightforward.
  Currently the E2E test deploys Kubeflow in a different namespace but not
  a different cluster. This won't allow us to simulatenously test both
  versions.

* So to test multiple versions we will need to spin up a separate GKE cluster.

Related to: kubeflow#599
k8s-ci-robot pushed a commit that referenced this pull request May 24, 2018
* ksonnet changes to support deploying the v1alpha2 TFJob operator.

* K8s doesn't support installing multiple versions of a CRD in the same cluster.
* So we add an option to choose which version to support.
* We don't add an E2E test in this PR because its not straightforward.
  Currently the E2E test deploys Kubeflow in a different namespace but not
  a different cluster. This won't allow us to simulatenously test both
  versions.

* So to test multiple versions we will need to spin up a separate GKE cluster.

Related to: #599

* Autoformat jsonnet.
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
…beflow#851)

* ksonnet changes to support deploying the v1alpha2 TFJob operator.

* K8s doesn't support installing multiple versions of a CRD in the same cluster.
* So we add an option to choose which version to support.
* We don't add an E2E test in this PR because its not straightforward.
  Currently the E2E test deploys Kubeflow in a different namespace but not
  a different cluster. This won't allow us to simulatenously test both
  versions.

* So to test multiple versions we will need to spin up a separate GKE cluster.

Related to: kubeflow#599

* Autoformat jsonnet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants