Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo for param defaultHttpProxyImage (#556) #584

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Apr 4, 2018

Related to #506


This change is Reviewable

@jlewi
Copy link
Contributor Author

jlewi commented Apr 4, 2018

/uncc @jimexist
/uncc @wbuchwalter
/assign @ankushagarwal
/assign @pdmack

@pdmack
Copy link
Member

pdmack commented Apr 4, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pdmack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a411387 into kubeflow:v0.1-branch Apr 4, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants