Fix bug with using LoadBalancer for JupyterHub. #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The two services were incorrectly using the same name. * The LB should not set the ClusterIP to None as this causes a problem when the service type is loadbalancer.
inc0
approved these changes
Feb 12, 2018
elenzio9
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two services were incorrectly using the same name.
The LB should not set the ClusterIP to None as this causes a problem
when the service type is loadbalancer.
Fix KubeFlow on AWS - tf-hub-lb not created and cannot change jupyterHubServiceType to loadbalancer #203