Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update katib components #2064

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Dec 8, 2018

  • Update katib components to support TFJob hyperparameter tuning
  • Allow katib studyjobcontroller to delete pods
  • Add ambassador annotation to katib-ui
  • Fixed katib url in centraldashboard
  • Fixed bug in update_components script

This change is Reviewable

@richardsliu
Copy link
Contributor Author

/assign @YujiOshima

@YujiOshima
Copy link
Contributor

@richardsliu Thanks! /lgtm

@YujiOshima
Copy link
Contributor

@richardsliu Could you remove vizier-core NodePort? Related #1982.

@richardsliu
Copy link
Contributor Author

@YujiOshima Done.

@YujiOshima
Copy link
Contributor

Thanks! LGTM but I don't have lgtm, approve permission.

@richardsliu
Copy link
Contributor Author

/assign @lluunn

@lluunn
Copy link
Contributor

lluunn commented Dec 11, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richardsliu richardsliu merged commit 0e4c9da into kubeflow:master Dec 11, 2018
@k8s-ci-robot
Copy link
Contributor

@richardsliu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-presubmit f518aae link /test kubeflow-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardsliu richardsliu deleted the update_katib branch September 5, 2019 19:06
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants