Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #1717 upstream v0.3 branch #1884

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Oct 29, 2018

Related to #1883


This change is Reviewable

* The UI isn't able to list jobs in all namespaces because the
  cluster role binding isn't using the correct role

Related to kubeflow/training-operator#836
@jlewi
Copy link
Contributor Author

jlewi commented Oct 29, 2018

/assign @richardsliu

@jlewi
Copy link
Contributor Author

jlewi commented Oct 31, 2018

/test all

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c6e6b0f into kubeflow:v0.3-branch Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants