Weaveflux version 0.1.2. #1434
Merged
Weaveflux version 0.1.2. #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdmack
suggested changes
Aug 27, 2018
| @@ -4,7 +4,7 @@ | |||
| // @shortDescription A Flux meets Kubeflow | |||
| // @param name string Name to give to each of the components | |||
| // @optionalParam giturl string null Your default git URL. | |||
| // @optionalParam serviceType string ClusterIP The service type for WeaveFlux. | |||
| // @optionalParam serviceType string NodePort The service type for WeaveFlux. | |||
There was a problem hiding this comment.
I think this is the same as @jlewi point before. We should default to ClusterIP.
|
/assign @pdmack |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* fixed and rebased * new v0.1.2 * ClusterIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last PR somehow lost data in rebase. Attempt to fix this
This change is