Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl #2635

Closed
kkasravi opened this issue Mar 6, 2019 · 3 comments
Closed

kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl #2635

kkasravi opened this issue Mar 6, 2019 · 3 comments
Labels
area/kfctl priority/p1

Comments

@kkasravi
Copy link
Contributor

kkasravi commented Mar 6, 2019

Currently both package managers dynamically load their .so (ksonnet.so, kustomize.so).
We should go back to a build option where these are statically linked in.
@kkasravi
Copy link
Contributor Author

kkasravi commented Mar 6, 2019

/area kfctl

@kkasravi
Copy link
Contributor Author

kkasravi commented Mar 6, 2019

/priority p1

@kkasravi kkasravi mentioned this issue Mar 11, 2019
Merged
7 tasks
kkasravi pushed a commit to kkasravi/kubeflow that referenced this issue Mar 11, 2019
fixes 'kfctl - provide option (default) to statically link ksonnet an…
68b231e 
…d kustomize into kfctl kubeflow#2635'
kkasravi pushed a commit to kkasravi/kubeflow that referenced this issue Mar 11, 2019
fixes 'kfctl - provide option (default) to statically link ksonnet an…
8c11e3f 
…d kustomize into kfctl kubeflow#2635'
kkasravi pushed a commit to kkasravi/kubeflow that referenced this issue Mar 11, 2019
fixes 'kfctl - provide option (default) to statically link ksonnet an…
5b9523d 
…d kustomize into kfctl kubeflow#2635'
k8s-ci-robot pushed a commit that referenced this issue Mar 12, 2019
@kkasravi @k8s-ci-robot
fixes 'add kustomize support to kfctl' (#2673)
699c873 
* fixes 'add kustomize to kfctl'

* fixes 'kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl #2635'

* fixes 'kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl #2635'

* fixes 'kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl #2635'

* document what forms the version cli can have

* cleanup for static kfctl, fix for k8sSpecs, fix for --version pull/id/head
@kkasravi
Copy link
Contributor Author

fixed in #2673

saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 11, 2021
@kkasravi @k8s-ci-robot
fixes 'add kustomize support to kfctl' (kubeflow#2673)
2f4f652 
* fixes 'add kustomize to kfctl'

* fixes 'kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl kubeflow#2635'

* fixes 'kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl kubeflow#2635'

* fixes 'kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl kubeflow#2635'

* document what forms the version cli can have

* cleanup for static kfctl, fix for k8sSpecs, fix for --version pull/id/head
saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 12, 2021
@kkasravi @k8s-ci-robot
fixes 'add kustomize support to kfctl' (kubeflow#2673)
7896cb6 
* fixes 'add kustomize to kfctl'

* fixes 'kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl kubeflow#2635'

* fixes 'kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl kubeflow#2635'

* fixes 'kfctl - provide option (default) to statically link ksonnet and kustomize into kfctl kubeflow#2635'

* document what forms the version cli can have

* cleanup for static kfctl, fix for k8sSpecs, fix for --version pull/id/head
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kfctl priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkasravi @k8s-ci-robot