Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easy to customizes PVs attached to Jupyter pods #1125

Closed
jlewi opened this issue Jul 5, 2018 · 2 comments
Closed

Make it easy to customizes PVs attached to Jupyter pods #1125

jlewi opened this issue Jul 5, 2018 · 2 comments
Labels
area/jupyter Issues related to Jupyter area/0.3.0 priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented Jul 5, 2018

A common use case is users will want to attach a PV pointing at a shared filesystem to their Jupyter pods.

We should make it easy to customize Jupyter so that users can specify PVs that should be attached to all pods.

#56 is a general issue to make Jupyter pods more customizable.
@jlewi jlewi added area/jupyter Issues related to Jupyter area/0.3.0 labels Jul 5, 2018
@pdmack
Copy link
Member

pdmack commented Jul 11, 2018

#34

@jlewi
Copy link
Contributor Author

jlewi commented Aug 10, 2018

#34 Is about adding a UI element that makes it possible to add specific PVs to a specific Jupyter pod.

This issue was about making it easy to configure Jupyter to attach a given set of PVs to all jupyter pods.
This is possible via the environment variable
KF_PVC_LIST
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/kubeform_spawner.py#L241

This is mapped to the disks prototype parameter
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/jupyterhub.libsonnet#L153

So this is fixed.

@jlewi jlewi closed this as completed Aug 10, 2018
surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
@jlewi
Fix certmanager race condition and version numbers. (kubeflow#1134)
f0de832 
* To fix the race condition with certmanager (kubeflow#1125) we move the KF
  issuer into a separate package from the package deploying kubeflow.
  This way we can wait for cert-manager to start before deploying resources.

* Labels need to be immutable otherwise upgrades won't work (see kubeflow#1131).
  So remove version number from common labels and application selector
  so that apply will work to update resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/jupyter Issues related to Jupyter area/0.3.0 priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @pdmack