Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(probe): directly fetch kubearmor pods from k8s api instead of listing nodes #438

Merged
merged 1 commit into from
May 27, 2024

Conversation

daemon1024
Copy link
Member

this approach fixes panic in case kubearmor is not running on a node for some reason

Fixes #435

@daemon1024 daemon1024 changed the title fix(probe): directly ftech kubearmor pods from k8s api instead of listing nodes fix(probe): directly fetch kubearmor pods from k8s api instead of listing nodes May 21, 2024
probe/probe.go Outdated Show resolved Hide resolved
@daemon1024 daemon1024 force-pushed the fix-probe branch 2 times, most recently from 5db94a4 to eb1a7cd Compare May 27, 2024 05:21
…ting nodes

this approach fixes panic in case kubearmor is not running on a node for some reason

Signed-off-by: daemon1024 <barun1024@gmail.com>
Copy link
Member

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DelusionalOptimist DelusionalOptimist merged commit 39b65a1 into main May 27, 2024
13 checks passed
@DelusionalOptimist DelusionalOptimist deleted the fix-probe branch May 27, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve karmor probe error handling
2 participants