Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install): Probe KubeArmor after installing #335

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

daemon1024
Copy link
Member

@daemon1024 daemon1024 commented Jun 22, 2023

Fixes #334

Refactored Probe Code to return probe information before printing it
Leveraging the API then in Install to extract enforcement data

Screenshot when Enforcement Works
image

When Enforcement doesn't work
image

@daemon1024 daemon1024 force-pushed the enhance-install branch 2 times, most recently from abfe6d5 to 986605e Compare June 22, 2023 10:20
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

k8s/env.go Show resolved Hide resolved
probe/probe.go Show resolved Hide resolved
Copy link
Member

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking mostly good. Just some nits.

install/install.go Outdated Show resolved Hide resolved
install/install.go Outdated Show resolved Hide resolved
…s enabled or not

Signed-off-by: daemon1024 <barun1024@gmail.com>
@daemon1024 daemon1024 merged commit b814344 into kubearmor:main Jun 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

karmor install to check if the target env supports enforcement
3 participants