refactor(deps): ImagePullPolicy updated in install.go #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rootxrishabh <risrock02@gmail.com>
|
@DelusionalOptimist can we keep this handled once we move to new KubeArmor controller? and Helm not sure what exactly is the roadmap for installation. @rksharma95 how will this be handled when we have Operator based deployment. Would we need these options in the Operator CRD? |
yes we'll need to handle it separately if we want to have this option in operator based deployment, we would require to add this option in operator crd. |
|
Folks, this is what the roadmap to helm looks like - kubearmor/KubeArmor#1256 |
|
@daemon1024 is this good to merge? |
|
Yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rootxrishabh risrock02@gmail.com
fixes: #307
This lets karmor pull images present locally when installing karmor using the
--localflag. This is useful when you want to avoid unnecessary image pulls and speed up pod startup times.