-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Connect with discovery-engine to recommend Kyverno policies #303
Merged
nyrahul
merged 1 commit into
kubearmor:main
from
Vyom-Yadav:recommendAdmissionControllerPolicies
Apr 24, 2023
Merged
feat: Connect with discovery-engine to recommend Kyverno policies #303
nyrahul
merged 1 commit into
kubearmor:main
from
Vyom-Yadav:recommendAdmissionControllerPolicies
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vyom-Yadav
force-pushed
the
recommendAdmissionControllerPolicies
branch
from
April 1, 2023 13:16
23b3a90
to
8e1cbfe
Compare
CI failure is due to dependency on updated worker protobuf. |
nyrahul
requested changes
Apr 1, 2023
Vyom-Yadav
force-pushed
the
recommendAdmissionControllerPolicies
branch
5 times, most recently
from
April 4, 2023 17:56
5e7714e
to
7b13661
Compare
Vyom-Yadav
force-pushed
the
recommendAdmissionControllerPolicies
branch
from
April 13, 2023 06:06
7b13661
to
c993ec4
Compare
daemon1024
reviewed
Apr 19, 2023
Vyom-Yadav
force-pushed
the
recommendAdmissionControllerPolicies
branch
2 times, most recently
from
April 19, 2023 08:31
6e95397
to
f839570
Compare
Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com>
Vyom-Yadav
force-pushed
the
recommendAdmissionControllerPolicies
branch
from
April 19, 2023 15:44
f839570
to
caeba1f
Compare
PrimalPimmy
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 tested locally
daemon1024
approved these changes
Apr 21, 2023
@nyrahul Can you please LGTM if the changes look good? |
nyrahul
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vyom-Yadav jackhammervyom@gmail.com
Kyverno policy recommendation is spread across 3 PRs including this one:
Explanation:
Unlike other recommended policies, admission controller policies are fetched from Discovery-Engine. The client does not generate any admission controller policies.
Admission controller policies recommendation does not require downloading the images, they can be directly fetched from Discovery Engine.
CLI is extended with another flag for
recommend
: (-p, --policy
)Policies are being currently fetched from my fork of
policy-templates
, change would be required after merging kubearmor/policy-templates#1037.Recommendation Logs: https://gist.github.com/Vyom-Yadav/17d2baf7164c7204a4237b2b3efb88b6