refractor summary api

[Prateeknandle]

Signed-off-by: Prateeknandle prateeknandle@gmail.com
refactoring summary api:
changes :

• returning the summary output when GetSummary() is called
• printing the output is now done by Summary() func, when comand is used

after this we can use summary api to get the karmor summary command output rather than executing command in code.

[rksharma95]

LGTM 👍 PTAL at comment by @yasin-cs-ko-ak

[yasin-cs-ko-ak]

Good Job!
LGTM

[yasin-cs-ko-ak]

@Prateeknandle If you can attach a screenshot of a JSON output, that would be better.

[Prateeknandle]

screenshot was not possible because summary is big, therefore pasting the output with command

prateek@prateek-lenovo-ideapad-310-15isk:~/go/src/github.com/kubearmor/discovery-engine$ ~/go/bin/karmor summary -t network -o json
local port to be used for port forwarding discovery-engine-746fccb855-d9c4r: 32827 
{
    "PodName": "mysql-76ddc6ddc4-279dx",
    "ClusterName": "default",
    "Namespace": "wordpress-mysql",
    "Label": "app=mysql",
    "ContainerName": "mysql",
    "IngressConnection": [
        {
            "Protocol": "TCPv6",
            "Command": "/usr/sbin/mysqld",
            "IP": "pod/wordpress-787f45786f-84dr6",
            "Port": "3306",
            "Labels": "app=wordpress",
            "Namespace": "wordpress-mysql",
            "Count": "1",
            "UpdatedTime": "Tue Feb 14 08:00:03 UTC 2023"
        }
    ],
    "EgressConnection": [
        {
            "Protocol": "AF_UNIX",
            "Command": "/usr/bin/mysqladmin",
            "IP": "/var/run/mysqld/mysqld.sock",
            "Port": "0",
            "Count": "1",
            "UpdatedTime": "Tue Feb 14 07:59:57 UTC 2023"
        }
    ],
    "BindConnection": [
        {
            "Protocol": "AF_INET6",
            "Command": "/usr/sbin/mysqld",
            "Count": "1",
            "UpdatedTime": "Tue Feb 14 08:00:00 UTC 2023",
            "BindPort": "3306",
            "BindAddress": "::"
        }
    ]
}
{
    "PodName": "wordpress-787f45786f-84dr6",
    "ClusterName": "default",
    "Namespace": "wordpress-mysql",
    "Label": "app=wordpress",
    "ContainerName": "wordpress",
    "EgressConnection": [
        {
            "Protocol": "TCP",
            "Command": "/usr/local/bin/php",
            "IP": "svc/mysql",
            "Port": "3306",
            "Labels": "app=mysql",
            "Namespace": "wordpress-mysql",
            "Count": "7",
            "UpdatedTime": "Tue Feb 14 07:59:43 UTC 2023"
        }
    ]
}

[Prateeknandle]

Here's a glance to it

[rksharma95]

@yasin-cs-ko-ak is it okay to merge this PR now?

@rksharma95 Let @seswarrajan take look at it once and let eswar merge this. Because previously he was the one review it. That's why. I hope there is no issue with that.

[Prateeknandle]

actually tests for summary are ready, those tests are dependent on this pr

[rksharma95]

@Prateeknandle @yasin-cs-ko-ak IMO we're good to merge it.
// cc: @seswarrajan