Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating ginkgo test based on updated policy-template #264

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

Prateeknandle
Copy link
Contributor

Signed-off-by: Prateeknandle prateeknandle@gmail.com

@vishnusomank
Copy link
Contributor

hey @Prateeknandle rather than reducing the number of matched policies it'll be better if you can update the xx-least-functionality-execute-package-management-process-in-container.yaml under tests/recommend/res/out/wordpress-mysql-wordpress and tests/recommend/res/out/ubuntu-18-04 with this yaml
cc: @PrimalPimmy

@Prateeknandle
Copy link
Contributor Author

@vishnusomank updated the pr

Copy link
Contributor

@vishnusomank vishnusomank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prateeknandle
Copy link
Contributor Author

can we merge this?

@vishnusomank
Copy link
Contributor

can we merge this?

can you squash the commits?

@vishnusomank vishnusomank linked an issue Feb 10, 2023 that may be closed by this pull request
Signed-off-by: Prateeknandle <prateeknandle@gmail.com>
@Prateeknandle
Copy link
Contributor Author

can we merge this?

can you squash the commits?

done

@Prateeknandle
Copy link
Contributor Author

@vishnusomank can we merge this, there are some prs depending on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Ginkgo tests are failing in some recent pr
2 participants