Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add capabilities support for BPFLSM #1543

Merged
merged 1 commit into from
Feb 13, 2024
Merged

feat: Add capabilities support for BPFLSM #1543

merged 1 commit into from
Feb 13, 2024

Conversation

Aryan-sharma11
Copy link
Member

@Aryan-sharma11 Aryan-sharma11 commented Dec 13, 2023 •
edited
Loading

Purpose of PR?:

Fixes #1538

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
This PR adds the feature to support enforcement of capabilities rule in BPFLSM.

  • We are making use of CAPABLE hook for the purpose. It by default provides us with the capabillity being used by the process.
  • Sample policy .

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@Aryan-sharma11 Aryan-sharma11 marked this pull request as draft December 13, 2023 19:19
@Aryan-sharma11 Aryan-sharma11 force-pushed the enforc_cap branch 5 times, most recently from e9d56ea to b63b6d8 Compare December 19, 2023 05:48
@Aryan-sharma11 Aryan-sharma11 force-pushed the enforc_cap branch 8 times, most recently from c5838a0 to 97c4b1c Compare January 8, 2024 05:32
@Aryan-sharma11 Aryan-sharma11 marked this pull request as ready for review January 8, 2024 18:42
@Aryan-sharma11 Aryan-sharma11 force-pushed the enforc_cap branch 2 times, most recently from 40cb640 to aaa0d85 Compare January 9, 2024 07:08
daemon1024
daemon1024 previously approved these changes Jan 9, 2024
View reviewed changes
@Aryan-sharma11 Aryan-sharma11 mentioned this pull request Jan 23, 2024
Open
2 tasks
Prateeknandle
Prateeknandle previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@Prateeknandle Prateeknandle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
Great work @Aryan-sharma11

@daemon1024
Copy link
Member

Need to handle edge case where fromsource might be missing

@Aryan-sharma11
feat: added capability hook
042783d 
Signed-off-by: Aryan-sharma11 <aryan1126.sharma@gmail.com>
@daemon1024 daemon1024 merged commit d12c30f into kubearmor:main Feb 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daemon1024 daemon1024 daemon1024 approved these changes

@Prateeknandle Prateeknandle Prateeknandle approved these changes

@DelusionalOptimist DelusionalOptimist Awaiting requested review from DelusionalOptimist

@rksharma95 rksharma95 Awaiting requested review from rksharma95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(enforcer) : Capabilities support
3 participants
@Aryan-sharma11 @daemon1024 @Prateeknandle