Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Provides documentation on Kubearmor container visibility #1028

Merged
merged 3 commits into from
Jan 30, 2023
Merged

docs: Provides documentation on Kubearmor container visibility #1028

merged 3 commits into from
Jan 30, 2023

Conversation

TheRealSibasishBehera
Copy link
Contributor

Resolves Issue #481:

Provides documentation for kubearmor container visibility

This PR provides docs for feature mentioned in issue #126 and #398

@TheRealSibasishBehera
Documentation on kuberarmor visibility added
780b34c 
Signed-off-by: sibashi <fangedhamster3114@gmail.com>
nyrahul
nyrahul previously requested changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. Please find my comments.

getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
@TheRealSibasishBehera
Fix: changed to wordpress-sql as example
d87f6e6 
Signed-off-by: sibashi <fangedhamster3114@gmail.com>
@TheRealSibasishBehera
Copy link
Contributor Author

@nyrahul i worked on the issues ,
can you please review them

@nyrahul nyrahul requested a review from Ankurk99 January 24, 2023 08:10
Ankurk99
Ankurk99 requested changes Jan 25, 2023
View reviewed changes
Copy link
Member

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we include host visibility doc in the same page? Wdyt?
I also have some suggestions, ptal at inline comments

getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
getting-started/kubearmor_visibility.md Outdated Show resolved Hide resolved
@TheRealSibasishBehera
Copy link
Contributor Author

TheRealSibasishBehera commented Jan 25, 2023 •
edited
Loading

Why don't we include host visibility doc in the same page? Wdyt? I also have some suggestions, ptal at inline comments

Thanks for reviewing , i will fix the issues

I think we can include host visibility doc

If i am right host visibility is not enabled by default and we can use kubectl annotate node for that

Are the stats related to host visibility also fetched with karmor logs ?

@Ankurk99
Copy link
Member

Why don't we include host visibility doc in the same page? Wdyt? I also have some suggestions, ptal at inline comments

Thanks for reviewing , i will fix the issues

I think we can include host visibility doc

If i am right host visibility is not enabled by default and we can use kubectl annotate node for that

Correct

Are the stats related to host visibility also fetched with karmor logs ?

Yes, karmor logs has that.

@TheRealSibasishBehera
Added docs on host visibility, fixed log to logs
18ec77b 
Signed-off-by: sibashi <fangedhamster3114@gmail.com>
@Ankurk99
Copy link
Member

Awesome! Congratulations on your first PR!

@Ankurk99 Ankurk99 dismissed nyrahul’s stale review January 30, 2023 05:21

Review comments addressed

@Ankurk99 Ankurk99 merged commit a316f74 into kubearmor:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ankurk99 Ankurk99 Ankurk99 approved these changes

@nyrahul nyrahul nyrahul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheRealSibasishBehera @Ankurk99 @nyrahul