Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): updates for slack link #1023

Merged
merged 1 commit into from
Dec 22, 2022
Merged

docs(readme): updates for slack link #1023

merged 1 commit into from
Dec 22, 2022

Conversation

nyrahul
Copy link
Contributor

@nyrahul nyrahul commented Dec 19, 2022 •
edited
Loading

Purpose of PR?:

Fixes #1020

Does this PR introduce a breaking change?
No

Checklist:

  • Bug fix. Fixes Documentation: Slack link in README.md not working #1020
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests (NA)
  • Commit has integration tests (NA)

@daemon1024
Copy link
Member

Noting the runners are not available to repos by default need to enable access to them per repo even if it's available to the org.

Ref https://docs.github.com/en/actions/using-github-hosted-runners/controlling-access-to-larger-runners#changing-the-access-policy-of-a-runner-group

@nyrahul
removed heroku slack links from the README.
eb80c72 
Signed-off-by: Rahul Jadhav <nyrahul@gmail.com>
@nyrahul nyrahul changed the title docs(GH actions, readme): use better GH runners and readme updates for slack link docs(readme): updates for slack link Dec 22, 2022
@nyrahul
Copy link
Contributor Author

nyrahul commented Dec 22, 2022 •
edited
Loading

Removed the GH runners' commit from the PR. Fixing just the readme doc for the slack link and other readme fixes. Folks are having issues joining slack, hence the quick fix.
@daemon1024 , can you skim through and check? Thanks

Ankurk99
Ankurk99 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@daemon1024 daemon1024 merged commit 7d59486 into kubearmor:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ankurk99 Ankurk99 Ankurk99 approved these changes

@daemon1024 daemon1024 daemon1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: Slack link in README.md not working
3 participants
@nyrahul @daemon1024 @Ankurk99