-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudStorage v2 🎉 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2 of CloudStorage will move to a new, improved API allowing for a ton of DX improvements and new features in the future.
Storage Providers
Currently (v1), iOS will automatically use iCloud as a storage provider while other platforms (Android, Web) will fallback to Google Drive. In v2, both of these will be defined as "Storage Providers" and separated from each other more clearly. In the short-term, this allows for Google Drive to be used on iOS, too. In the long-term, this modular set-up would enable additional storage providers such as Firebase to be added. This keeps a simple API with strong defaults (iCloud and Google Drive) while simultaneously allowing the developer to use other storage providers, if they so prefer.
This also has the benefit of cleaning up the core
CloudStorage
API, moving all of the configuration methods to a new configuration object directly passed to the storage provider.