fix(expo): fixed config plugin crashing build with no options passed

kuatsu · Oct 2, 2024 · fe34eaf · fe34eaf
1 parent 023e93d
commit fe34eaf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/src/expo-plugin/types/index.ts b/src/expo-plugin/types/index.ts
@@ -1,10 +1,12 @@
-export interface RNCloudStorageConfigPluginOptions {
-  /**
-   * The iCloud container environment to use. Defaults to 'Production'.
-   */
-  iCloudContainerEnvironment?: 'Production' | 'Development';
-  /**
-   * The iCloud container identifier to use. Defaults to `iCloud.{appBundleIdentifier}`
-   */
-  iCloudContainerIdentifier?: string;
-}
+export type RNCloudStorageConfigPluginOptions =
+  | {
+      /**
+       * The iCloud container environment to use. Defaults to 'Production'.
+       */
+      iCloudContainerEnvironment?: 'Production' | 'Development';
+      /**
+       * The iCloud container identifier to use. Defaults to `iCloud.{appBundleIdentifier}`
+       */
+      iCloudContainerIdentifier?: string;
+    }
+  | undefined;
diff --git a/src/expo-plugin/withRNCloudStorageIos.ts b/src/expo-plugin/withRNCloudStorageIos.ts
@@ -3,7 +3,7 @@ import { type ExpoConfig } from '@expo/config-types';
 import type { RNCloudStorageConfigPluginOptions } from './types';
 
 const getICloudContainerIdentifier = (config: ExpoConfig, options: RNCloudStorageConfigPluginOptions) => {
-  if (options.iCloudContainerIdentifier) return options.iCloudContainerIdentifier;
+  if (options?.iCloudContainerIdentifier) return options.iCloudContainerIdentifier;
 
   if (!config?.ios?.bundleIdentifier) throw new Error('Missing iOS bundle identifier');
   return `iCloud.${config.ios.bundleIdentifier}`;