Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint for https://github.com/sickill/rainbow/issues/112 and minor changes #119

Closed
wants to merge 5 commits into from
Closed

Lint for https://github.com/sickill/rainbow/issues/112 and minor changes #119

wants to merge 5 commits into from

Commits on Jul 30, 2022

  1. Upgrade rubocop to 1.32 

    * regenerate default .rubocop and .rubocop_todo.yml(rubocop --init && rubocop --auto-gen-config)
* drop support for Ruby 2.4 and 2.5
* upgrade rubocop version to 1.32.0

https://endoflife.date/ruby

ruby 2.5 eol is 4 years and 7 months ago(25 Dec 2017)
ruby 2.6 eol is 3 years and 7 months ago(25 Dec 2018)

[rubocop drop support for Ruby 2.5 and JRuby 9.2 (CRuby 2.5 compatible) in v1.29.0](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#changes-4)
[rubocop Drop support for Ruby 2.4 in v1.13.0](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#changes-21)

[last rubocop version that supports ruby2.4 is v1.12.1](https://rubygems.org/gems/rubocop/versions/1.12.1), we'll still missing so many features and bugfixes for rubocop

So I suggest dropping support for Ruby 2.4 and make ruby requirement to >= 2.6.0(align with rubocop to use the lastest version of rubocop)
    @liijunwei
    liijunwei committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    0ad357c View commit details
    Browse the repository at this point in the history

  2. Disable Naming/MethodName for global method Rainbow

    @liijunwei
    liijunwei committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    4529697 View commit details
    Browse the repository at this point in the history

  3. Update README and setup bin dir

    @liijunwei
    liijunwei committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    d81cc97 View commit details
    Browse the repository at this point in the history

  4. Code cleanup

    @liijunwei
    liijunwei committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    173dcba View commit details
    Browse the repository at this point in the history

  5. Add changelog items

    @liijunwei
    liijunwei committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    ca0f375 View commit details
    Browse the repository at this point in the history