Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow actions to return ActionResult values to represent errors #76

Merged
merged 19 commits into from
Dec 2, 2023
Merged

Allow actions to return ActionResult values to represent errors #76

merged 19 commits into from
Dec 2, 2023

Commits on Nov 29, 2023

  1. First attempt to add a Result return type to actions. 

    This breaks all clients.
    @timburks
    timburks committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    546dfab View commit details
    Browse the repository at this point in the history

  2. Use a dedicated type for errors

    @timburks
    timburks committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f844570 View commit details
    Browse the repository at this point in the history

  3. publish CommandError

    @timburks
    timburks committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f45bf4f View commit details
    Browse the repository at this point in the history

  4. fail with an error code

    @timburks
    timburks committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    162465f View commit details
    Browse the repository at this point in the history

  5. rename action to action_with_result 

    (the original action handling is still broken)
    @timburks
    timburks committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    47f9efe View commit details
    Browse the repository at this point in the history

  6. minor cleanup, rename CommandError to ActionError and add ActionResul… 

    …t type
    @timburks
    timburks committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f0c37e6 View commit details
    Browse the repository at this point in the history

  7. fix examples in comments

    @timburks
    timburks committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    68212d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. restore original support for action, fix new doc tests

    @timburks
    timburks committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6155c51 View commit details
    Browse the repository at this point in the history

  2. flip the order of "match action" expressions to minimize the diffs fo… 

    …r this change
    @timburks
    timburks committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    b04fb77 View commit details
    Browse the repository at this point in the history

  3. Ensure that only one of action and action_with_result is set.

    @timburks
    timburks committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6b6a12d View commit details
    Browse the repository at this point in the history

  4. Simplify checks with is_some()

    @timburks
    timburks committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    8584ad5 View commit details
    Browse the repository at this point in the history

  5. Add tests to verify that action and action_with_result cannot both be… 

    … set.
    @timburks
    timburks committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    179cf4e View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Add tests for action_with_result.

    @timburks
    timburks committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6cee1a8 View commit details
    Browse the repository at this point in the history

  2. Use "hello" as the command name in tests.

    @timburks
    timburks committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    37a8931 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Run cargo fmt --

    @timburks
    timburks committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    99ea4c3 View commit details
    Browse the repository at this point in the history

  2. Add run_with_result to App and Command

    @timburks
    timburks committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    7be4400 View commit details
    Browse the repository at this point in the history

  3. cargo fmt --

    @timburks
    timburks committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    a8ff95d View commit details
    Browse the repository at this point in the history

  4. Add inline test for app.run_with_result, remove incorrect comment abo… 

    …ut error (my misunderstanding)
    @timburks
    timburks committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    cfc324f View commit details
    Browse the repository at this point in the history

  5. Test result values from run_with_result()

    @timburks
    timburks committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    dd77618 View commit details
    Browse the repository at this point in the history