Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add per model metrics #86

Closed
wants to merge 2 commits into from
Closed

feat: Add per model metrics #86

wants to merge 2 commits into from

Conversation

ScrapCodes
Copy link
Contributor

@ScrapCodes ScrapCodes commented Feb 24, 2023 •
edited
Loading

Motivation

Fixes #60

Modifications

  1. Added a new configuration parameter, i.e. per_model_metrics, when true metrics are labeled with modelid for each configured metric.

Result

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ScrapCodes
To complete the pull request process, please assign pvaneck after the PR has been reviewed.
You can assign the PR to them by writing /assign @pvaneck in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ScrapCodes
Copy link
Contributor Author

/hold

@ScrapCodes ScrapCodes force-pushed the per_model_metrics branch 4 times, most recently from e006c2a to 16e08ec Compare March 6, 2023 10:10
@ScrapCodes ScrapCodes changed the title wip: Add per model metrics feat: Add per model metrics Mar 6, 2023
@ScrapCodes
Copy link
Contributor Author

/unhold

@ScrapCodes
Add modelid and vmodelid labels to metrics.
52cea64 
Signed-off-by: Prashant Sharma <prashsh1@in.ibm.com>
@kserve-oss-bot
Copy link
Collaborator

@ScrapCodes: No presubmit jobs available for kserve/modelmesh@main

In response to this:

/retest (since these tests are working locally.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ScrapCodes
Copy link
Contributor Author

/retest

@ScrapCodes
Copy link
Contributor Author

@VedantMahabaleshwarkar is also working on this issue, thus he is going to continue this work !

@ScrapCodes
Merge branch 'main' into per_model_metrics
0861480 
Signed-off-by: Prashant Sharma <scrapcodes@gmail.com>
@ckadner
Copy link
Member

ckadner commented Apr 13, 2023

@ScrapCodes -- you removed the do-not-merge/hold label indicating this PR is ready for review and potential merge?

You also wrote that @VedantMahabaleshwarkar is going to continue to work on this PR. Should this PR remain in [WIP] / draft mode?

@ScrapCodes ScrapCodes marked this pull request as draft April 13, 2023 12:04
@ScrapCodes
Copy link
Contributor Author

Converted the PR to draft mode, let us wait for the answer from @VedantMahabaleshwarkar . Are you looking at this issue @VedantMahabaleshwarkar?

@VedantMahabaleshwarkar
Copy link
Contributor

@ScrapCodes Will have an update to the PR in a day or two. I'll push the commits to the source branch ScrapCodes:per_model_metrics so this same PR is updated with the latest.

@rafvasq rafvasq mentioned this pull request May 1, 2023
Merged
@VedantMahabaleshwarkar
Copy link
Contributor

replaced by #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VedantMahabaleshwarkar VedantMahabaleshwarkar

Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support individual model metrics
4 participants
@ScrapCodes @kserve-oss-bot @ckadner @VedantMahabaleshwarkar