Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add S390x support #138

Merged
merged 5 commits into from
Apr 19, 2024
Merged

feat: Add S390x support #138

merged 5 commits into from
Apr 19, 2024

Conversation

modassarrana89
Copy link
Contributor

Modifications

Added linux/s390x ( platform ) in the build github workflow

Result

https://github.com/modassarrana89/modelmesh/actions/runs/8688245342/job/23823937204 // Build operation run in local workflow is a success. Attached archieve log for refernece
logs_22763759557.zip

Signed-off-by: Modassar Rana <modassar.rana@ibm.com>
Added s390x architecture as build operation is successful.

Signed-off-by: Modassar Rana <modassar.rana@ibm.com>
@oss-prow-bot oss-prow-bot bot requested review from njhill and rafvasq April 15, 2024 12:05
@modassarrana89
Copy link
Contributor Author

@njhill @rafvasq Please review the change

Removed echo Version ( was added for testing local)

Signed-off-by: Modassar Rana <modassar.rana@ibm.com>
Removed unwanted space

Signed-off-by: Modassar Rana <modassar.rana@ibm.com>
@modassarrana89
Copy link
Contributor Author

@spolti Please merge , as you have approved the change.

@spolti
Copy link
Contributor

spolti commented Apr 16, 2024

@spolti Please merge , as you have approved the change.

It is up to @njhill and @rafvasq :)

@modassarrana89
Copy link
Contributor Author

@njhill & @rafvasq Please review & do the needful.

@rafvasq rafvasq requested a review from ckadner April 18, 2024 17:37
@rafvasq rafvasq changed the title Added S390x support feat: Add S390x support Apr 18, 2024
Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @modassarrana89, looks like GRPC added support for s390x a while ago. Please rebase this with main again when you can.

@modassarrana89
Copy link
Contributor Author

Thanks for the update @modassarrana89, looks like GRPC added support for s390x a while ago. Please rebase this with main again when you can.

I have done that. Can you please merge the PR now

Copy link
Member

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

oss-prow-bot bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: modassarrana89, rafvasq, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rafvasq rafvasq merged commit f8212c7 into kserve:main Apr 19, 2024
7 checks passed
@modassarrana89 modassarrana89 deleted the s390x branch May 27, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants