Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fs.exists function #47

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

mattzeunert
Copy link

exists's callback signature is just (value) instead of (err, value) so normally if the file exists it would be interpreted as an error because the first argument is true.

The change checks if the asyncFunction can return an error, if it can't it triggers a success.

@mattzeunert
Copy link
Author

Thanks Kris,

I've moved it to not modify Promise.js.

I haven't found a way to pass the arity to the conversion function without modifying Promise.js, so for now it assumes the function takes two arguments (a value and a callback).

@mik01aj
Copy link

mik01aj commented Aug 6, 2015

Hey guys, fs.exits an important function. Why is this PR waiting to be merged for 18 months? Is no-one using promised-io anymore? This is totally bizzare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants