Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update setup-ghidra #42

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Conversation

antoniovazquezblanco
Copy link
Contributor

No description provided.

@kotcrab
Copy link
Owner

kotcrab commented Jun 12, 2024

I'm not so sure about passing GH token just to download Ghidra.

@antoniovazquezblanco
Copy link
Contributor Author

That is optional. You may not pass it but if you run a lot of jobs consecutively you may hit API rate limiting.

I will remove it. If you ever hit API rate limiting it is just a matter of adding it back. :)

@antoniovazquezblanco antoniovazquezblanco changed the title ci: update setup-ghidra and bump java version ci: update setup-ghidra Jun 13, 2024
@antoniovazquezblanco
Copy link
Contributor Author

Done :)

@kotcrab
Copy link
Owner

kotcrab commented Jun 13, 2024

Thanks, I've never hit limits with the old plugins so I'd rather avoid it.
CI has failed though, seems like it's required.

@antoniovazquezblanco
Copy link
Contributor Author

Oh, it is not intended to be mandatory but I always pass the token. This is useful testing for me. I will find some time to look into it, fix it and get back to the PR. I will mark as a draft for the time being.

Thanks for the patience!

@antoniovazquezblanco
Copy link
Contributor Author

Found some time to do this :)

@kotcrab
Copy link
Owner

kotcrab commented Jun 15, 2024

Awesome looks like it works now. Can you update the publish workflow too?

@antoniovazquezblanco
Copy link
Contributor Author

Oops. Done!

BTW, you may be able to condense both files into one by using an "if" parameter in the publish step to check for tag pushes... :)

@kotcrab
Copy link
Owner

kotcrab commented Jun 15, 2024

Thanks!

Yeah, that's a good idea, I'll look into it.

@kotcrab kotcrab merged commit 19edf2c into kotcrab:master Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants