Fix HI16 relocation shift

kotcrab · May 19, 2024 · 05cb8f6 · 05cb8f6
1 parent 7939d59
commit 05cb8f6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,6 @@
+#### Version 19
+- Fixed HI16 relocation calculation when relocating to a very high address
+
 #### Version 18
 - Updated to Ghidra 11.0
 

diff --git a/src/main/kotlin/allegrex/format/elf/relocation/AllegrexRelocationApplicator.kt b/src/main/kotlin/allegrex/format/elf/relocation/AllegrexRelocationApplicator.kt
@@ -38,7 +38,7 @@ object AllegrexRelocationApplicator {
         newAddr += relocation.linkedLoValue
         newAddr += relocateToSect
         val newLo = (newAddr and 0xFFFF).toShort()
-        val newHi = (newAddr - newLo) shr 16
+        val newHi = (newAddr - newLo) ushr 16
         newInstr = (initialValue and 0xFFFF0000.toInt()) or newHi
       }
       AllegrexElfRelocationConstants.R_MIPS_LO16 -> {