fix: declare pino-pretty dependency #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonmasberg
force-pushed
the
fix/pino-pretty-dependency
branch
from
f293fe4
to
038e692
Compare
timonmasberg
previously approved these changes
Aug 10, 2023
Deployment Preview🏁 This PR has been closed. No deployment preview is available. |
timonmasberg
approved these changes
Aug 10, 2023
JSPRH
force-pushed
the
fix/pino-pretty-dependency
branch
from
9ca210d
to
760d545
Compare
|
Kudos, SonarCloud Quality Gate passed! |
timonmasberg
added a commit
that referenced
this pull request
Aug 10, 2023
Co-authored-by: Timon Masberg <contact@timonmasberg.com>
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Declare the
pino-prettydependency so NX dependency tree shaking is aware of it and includes it in the distpackage.json.Checklist:
the Conventional Commits specification.
I have added tests (unit and E2E if user-facing) that prove my fix is effective or that my feature works,Coverage > 80% and not less than the current coverage of the main branch.
maininto your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).