Add option to disable keeping download url

Refs https://discourse.jabref.org/t/import-adds-pdf-link-and-url-to-file-entry/4484/

src/main/java/org/jabref/gui/linkedfile/DownloadLinkedFileAction.java

@@ -171,7 +171,8 @@ private void onSuccess(Path targetDirectory, Path downloadedFile) {
         }
         if (linkedFile.getSourceUrl().isEmpty() && LinkedFile.isOnlineLink(linkedFile.getLink())) {
             newLinkedFile.setSourceURL(linkedFile.getLink());
-        } else {
+        } else if (filePreferences.shouldKeepDownloadUrl()) {
+            // Add pref check to not store source URL
             newLinkedFile.setSourceURL(linkedFile.getSourceUrl());
         }
 

src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.fxml

@@ -20,6 +20,7 @@
     <CheckBox fx:id="generateNewKeyOnImport" text="%Generate a new key for imported entries (overwriting their default)"/>
     <CheckBox fx:id="warnAboutDuplicatesOnImport" text="%Warn about duplicates on import"/>
     <CheckBox fx:id="downloadLinkedOnlineFiles" text="%Download linked online files"/>
+    <CheckBox fx:id="keepDownloadUrl" text="%Store url for downloaded file" />
 
     <Label styleClass="sectionHeader" text="%Custom DOI URI"/>
     <HBox alignment="CENTER_LEFT" spacing="10.0">

src/main/java/org/jabref/gui/preferences/websearch/WebSearchTabViewModel.java

@@ -46,6 +46,7 @@ public class WebSearchTabViewModel implements PreferenceTabViewModel {
     private final BooleanProperty generateKeyOnImportProperty = new SimpleBooleanProperty();
     private final BooleanProperty warnAboutDuplicatesOnImportProperty = new SimpleBooleanProperty();
     private final BooleanProperty shouldDownloadLinkedOnlineFiles = new SimpleBooleanProperty();
+    private final BooleanProperty shouldkeepDownloadUrl = new SimpleBooleanProperty();
 
     private final BooleanProperty useCustomDOIProperty = new SimpleBooleanProperty();
     private final StringProperty useCustomDOINameProperty = new SimpleStringProperty("");
@@ -83,7 +84,7 @@ public void setValues() {
         generateKeyOnImportProperty.setValue(importerPreferences.isGenerateNewKeyOnImport());
         warnAboutDuplicatesOnImportProperty.setValue(importerPreferences.shouldWarnAboutDuplicatesOnImport());
         shouldDownloadLinkedOnlineFiles.setValue(filePreferences.shouldDownloadLinkedFiles());
-
+        shouldkeepDownloadUrl.setValue(filePreferences.shouldKeepDownloadUrl());
         useCustomDOIProperty.setValue(doiPreferences.isUseCustom());
         useCustomDOINameProperty.setValue(doiPreferences.getDefaultBaseURI());
 
@@ -110,7 +111,7 @@ public void storeSettings() {
         importerPreferences.setGenerateNewKeyOnImport(generateKeyOnImportProperty.getValue());
         importerPreferences.setWarnAboutDuplicatesOnImport(warnAboutDuplicatesOnImportProperty.getValue());
         filePreferences.setDownloadLinkedFiles(shouldDownloadLinkedOnlineFiles.getValue());
-
+        filePreferences.setKeepDownloadUrl(shouldkeepDownloadUrl.getValue());
         grobidPreferences.setGrobidEnabled(grobidEnabledProperty.getValue());
         grobidPreferences.setGrobidOptOut(grobidPreferences.isGrobidOptOut());
         grobidPreferences.setGrobidURL(grobidURLProperty.getValue());

src/main/java/org/jabref/preferences/FilePreferences.java

@@ -38,6 +38,7 @@ public class FilePreferences {
     private final ObjectProperty<Path> backupDirectory = new SimpleObjectProperty<>();
     private final BooleanProperty confirmDeleteLinkedFile = new SimpleBooleanProperty();
     private final BooleanProperty moveToTrash = new SimpleBooleanProperty();
+    private final BooleanProperty shouldKeepDownloadUrl = new SimpleBooleanProperty();
 
     public FilePreferences(String userAndHost,
                            String mainFileDirectory,
@@ -51,7 +52,8 @@ public FilePreferences(String userAndHost,
                            boolean createBackup,
                            Path backupDirectory,
                            boolean confirmDeleteLinkedFile,
-                           boolean moveToTrash) {
+                           boolean moveToTrash,
+                           boolean shouldKeepDownloadUrl) {
         this.userAndHost.setValue(userAndHost);
         this.mainFileDirectory.setValue(mainFileDirectory);
         this.storeFilesRelativeToBibFile.setValue(storeFilesRelativeToBibFile);
@@ -65,6 +67,7 @@ public FilePreferences(String userAndHost,
         this.backupDirectory.setValue(backupDirectory);
         this.confirmDeleteLinkedFile.setValue(confirmDeleteLinkedFile);
         this.moveToTrash.setValue(moveToTrash);
+        this.shouldKeepDownloadUrl.setValue(shouldKeepDownloadUrl);
     }
 
     public String getUserAndHost() {
@@ -214,4 +217,16 @@ public BooleanProperty moveToTrashProperty() {
     public void moveToTrash(boolean moveToTrash) {
         this.moveToTrash.set(moveToTrash);
     }
+
+    public boolean shouldKeepDownloadUrl() {
+        return shouldKeepDownloadUrl.get();
+    }
+
+    public BooleanProperty shouldKeepDownloadUrlProperty() {
+        return shouldKeepDownloadUrl;
+    }
+
+    public void setKeepDownloadUrl(boolean shouldKeepDownloadUrl) {
+        this.shouldKeepDownloadUrl.set(shouldKeepDownloadUrl);
+    }
 }

src/main/java/org/jabref/preferences/JabRefPreferences.java

@@ -105,6 +105,7 @@
 import org.jabref.logic.protectedterms.ProtectedTermsPreferences;
 import org.jabref.logic.push.CitationCommandString;
 import org.jabref.logic.remote.RemotePreferences;
+import org.jabref.logic.search.SearchPreferences;
 import org.jabref.logic.shared.prefs.SharedDatabasePreferences;
 import org.jabref.logic.shared.security.Password;
 import org.jabref.logic.util.OS;
@@ -453,6 +454,7 @@ public class JabRefPreferences implements PreferencesService {
     private static final String PREFS_EXPORT_PATH = "prefsExportPath";
     private static final String DOWNLOAD_LINKED_FILES = "downloadLinkedFiles";
     private static final String FULLTEXT_INDEX_LINKED_FILES = "fulltextIndexLinkedFiles";
+    private static final String KEEP_DOWNLOAD_URL ="keepDownloadUrl";
 
     // Helper string
     private static final String USER_HOME = System.getProperty("user.home");
@@ -2257,7 +2259,8 @@ public FilePreferences getFilePreferences() {
                 getPath(BACKUP_DIRECTORY, OS.getNativeDesktop().getBackupDirectory()),
                 getBoolean(CONFIRM_LINKED_FILE_DELETE),
                 // We make use of the fallback, because we need AWT being initialized, which is not the case at the constructor JabRefPreferences()
-                getBoolean(TRASH_INSTEAD_OF_DELETE, OS.getNativeDesktop().moveToTrashSupported()));
+                getBoolean(TRASH_INSTEAD_OF_DELETE, OS.getNativeDesktop().moveToTrashSupported()),
+                getBoolean(KEEP_DOWNLOAD_URL));
 
         EasyBind.listen(getInternalPreferences().getUserAndHostProperty(), (obs, oldValue, newValue) -> filePreferences.getUserAndHostProperty().setValue(newValue));
         EasyBind.listen(filePreferences.mainFileDirectoryProperty(), (obs, oldValue, newValue) -> put(MAIN_FILE_DIRECTORY, newValue));
@@ -2273,6 +2276,7 @@ public FilePreferences getFilePreferences() {
         EasyBind.listen(filePreferences.backupDirectoryProperty(), (obs, oldValue, newValue) -> put(BACKUP_DIRECTORY, newValue.toString()));
         EasyBind.listen(filePreferences.confirmDeleteLinkedFileProperty(), (obs, oldValue, newValue) -> putBoolean(CONFIRM_LINKED_FILE_DELETE, newValue));
         EasyBind.listen(filePreferences.moveToTrashProperty(), (obs, oldValue, newValue) -> putBoolean(TRASH_INSTEAD_OF_DELETE, newValue));
+        EasyBind.listen(filePreferences.shouldKeepDownloadUrlProperty(), (obs, oldValue, newValue) -> putBoolean(KEEP_DOWNLOAD_URL, newValue));
 
         return filePreferences;
     }

src/main/resources/l10n/JabRef_en.properties

@@ -2780,3 +2780,4 @@ Warning\:\ The\ selected\ directory\ is\ not\ a\ valid\ directory.=Warning: The
 
 Currently\ selected\ JStyle\:\ '%0' = Currently selected JStyle: '%0'
 Currently\ selected\ CSL\ Style\:\ '%0' = Currently selected CSL Style: '%0'
+Store\ url\ for\ downloaded\ file=Store url for downloaded file